Re: floating point support for i386 done, for record/replay

[Hui Zhu <teawater at gmail dot com>]

I think maybe you can post your patch and your example to gdb-patch to
let people review it.

Hui

On Sun, May 31, 2009 at 01:46, paawan oza <paawan1982@yahoo.com> wrote:
>
> Hi Hui,
> I have been going through GNU doc about how I can submit the patch (floating point record support).
> the process looked bit complicated as the patch involves more than 15 lines of change.
> I am not sure how to go ahead, because this is the very first time I am contributing.
> please guide me with that.
> I will be waiting for your reply.
> Regards,
> Oza.
>
> --- On Thu, 5/28/09, paawan oza <paawan1982@yahoo.com> wrote:
>
>> From: paawan oza <paawan1982@yahoo.com>
>> Subject: i386, floating point support done for record/replay
>> To: "Hui Zhu" <teawater@gmail.com>
>> Cc: "gdb ml" <gdb@sourceware.org>
>> Date: Thursday, May 28, 2009, 1:25 PM
>>
>> Hi Hui,
>>
>> I have finished the implementation part for i386 floating
>> point support
>> for record/replay.
>> I have tested with some small programs, and it gives
>> results as expected.
>> (As there are lots of floating point insns, not every insn
>> is tested, but coding is simple)
>> I am quiet excited about the patch and nervous at the same
>> time, as it is my first contribution : )
>> I have just concentrated mainly on making the things work,
>> rather than optimizing it.
>> please feel free to suggest any design change.
>>
>> please let me know how I can go ahead.
>>
>> Regards,
>> Oza.
>>
>>
>>
>>
>> --- On Sun, 5/24/09, Hui Zhu <teawater@gmail.com>
>> wrote:
>>
>> > From: Hui Zhu <teawater@gmail.com>
>> > Subject: Re: floating point support i386
>> implementation partially done
>> > To: "paawan oza" <paawan1982@yahoo.com>
>> > Cc: "gdb ml" <gdb@sourceware.org>
>> > Date: Sunday, May 24, 2009, 9:27 AM
>> > On Sun, May 24, 2009 at 03:03, paawan
>> > oza <paawan1982@yahoo.com>
>> > wrote:
>> > >
>> > > Hi Hui,
>> > >
>> > > floating point support patch is over for the
>> case
>> > > where ModR/M Byte is Within 00H to BFH.
>> > >
>> > > there are some doubts.
>> > >
>> > > 1) the insns like,
>> > > FRSTOR, FLDENV, FLDCW (which loads floating
>> point
>> > environment registers like status, control, tag etc..
>> > initializing part)
>> > > I think we need to record those also, upon
>> executing
>> > such insns.
>> > > what is your opinion?
>> > If this reg can be access by gdb, I think you need
>> deal
>> > with them.
>> >
>> > >
>> > >
>> > > otherwise, patch is ready : ),
>> > > of course I need to work on REG= support to
>> finish the
>> > rest of the record of FPU support.
>> > >
>> > Great!
>> >
>> > Thanks,
>> > Hui
>> >
>>
>>
>>
>>
>
>
>
>