Re: line_num of gdb_disassembly

[teawater <teawater at gmail dot com>]

Hi Pedro,

Thanks for your remind me about it.

I had checked the insight cvs-head version.
It just use "gdb_print_insn" and "print_asm_fn".

So change gdb_disassembly doesn't affect insight.

Thanks,
Hui

On Tue, Mar 10, 2009 at 04:17, Pedro Alves <pedro@codesourcery.com> wrote:
> Hi guys,
>
> On Monday 09 March 2009 19:50:56, Tom Tromey wrote:
>> >>>>> "teawater" == teawater ?<teawater@gmail.com> writes:
>>
>> teawater> I found that the argument line_num of gdb_disassembly isn't
>> teawater> used in anywhere. ?So maybe I can remove it.
>>
>> Go for it.
>>
>> teawater> And it can be checked in under the obvious rule, right?
>>
>> IMO, yes.
>>
>
> Hui, don't forget that gdb_* functions are part of (now zombie) libgdb's
> public interface. ?There's a chance that insight is using it. ?You're
> not obliged to, but it's always nice to check if insight will need
> fixing as well.
>
> --
> Pedro Alves
>