This is the mail archive of the gdb@sourceware.org mailing list for the GDB project.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

Re: (len % 1) != 0

From: "Bin Chen" <binary dot chen at gmail dot com>
To: "Eli Zaretskii" <eliz at gnu dot org>
Cc: gdb at sourceware dot org, drow at false dot org
Date: Sun, 17 Feb 2008 22:41:36 +0800
Subject: Re: (len % 1) != 0
References: <5800c1cc0802162157g3ac31acas4ae95585b9b2e263@mail.gmail.com> <E1JQkG0-0005DD-0k@fencepost.gnu.org>

Hi Daniel,

Is it a bug?

On Sun, Feb 17, 2008 at 10:12 PM, Eli Zaretskii <eliz@gnu.org> wrote:
> > Date: Sun, 17 Feb 2008 13:57:31 +0800
>  > From: "Bin Chen" <binary.chen@gmail.com>
>
>
> >
>  > Hello,
>  >
>  > In gdb/gdbserver/server.c,
>  >
>  > there is a line:
>  >
>  > if ((len % 1) != 0 || unhexify (mon, own_buf + 6, len / 2) != len / 2)
>  >
>  > I am curious that (len % 1) != 0 is always false, why put here?
>
>  It's probably a bug: they meant len % 2.
>

Follow-Ups:
- Re: (len % 1) != 0
  - From: Daniel Jacobowitz

References:
- (len % 1) != 0
  - From: Bin Chen
- Re: (len % 1) != 0
  - From: Eli Zaretskii

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]