This is the mail archive of the gdb@sources.redhat.com mailing list for the GDB project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Should push_target pop all targets?


Hello,

The current push_target code:

/* Find the proper stratum to install this target in. */

  for (prev = NULL, cur = target_stack; cur; prev = cur, cur = cur->next)
    {
      if ((int) (t->to_stratum) >= (int) (cur->target_ops->to_stratum))
        break;
    }

/* If there's already targets at this stratum, remove them. */

only pops targets at the stratum level being pushed. Doing this - changing the target underneath ones feet - just scares me.


I think this should be changed so that all targets above that one get poped. If they are still needed, they can be re-pushed.

I suspect this will affect core-file and thread targets ...
Andrew


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]