This is the mail archive of the gdb@sources.redhat.com mailing list for the GDB project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: bitrot in buildsym.c:start_subfile


> In buildsym.c there's this:
> 
> /* Start recording information about source code that came from an
>    included (or otherwise merged-in) source file with a different
>    name.  NAME is the name of the file (cannot be NULL), DIRNAME is
>    the directory in which it resides (or NULL if not known).  */
> 
> void
> start_subfile (char *name, char *dirname)
> {
> 
> 
> `name' cannot be NULL.
> 
> However, there's this:
> 
>   subfile->name = (name == NULL) ? NULL : savestring (name, strlen (name));
> 
> and this:
> 
>   if (subfile->name)
> 
> Am I missing something?

Doesn't look like it.  Guess the comment is wrong.  Any hints from the 
callers?

To figure out the full history will mean grubbing around in the old 
cygnus repository.  It might be easier to track that with a bug report.

enjoy,
Andrew



Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]