This is the mail archive of the gdb@sources.redhat.com mailing list for the GDB project.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]

Re: [RFA] Remove OS-specific defines (was: _WIN32?)

To: Eli Zaretskii <eliz at is dot elta dot co dot il>, ac131313 at cygnus dot com
Subject: Re: [RFA] Remove OS-specific defines (was: _WIN32?)
From: Kevin Buettner <kevinb at cygnus dot com>
Date: Mon, 7 May 2001 10:38:55 -0700
Cc: danny_r_smith_2001 at yahoo dot co dot nz, gdb at sources dot redhat dot com, mingw-users at lists dot sourceforge
References: <20010503211502.21716.qmail@web6401.mail.yahoo.com> <3AF1DAA0.3060702@cygnus.com> <200105071610.TAA24144@is.elta.co.il>

On May 7,  7:10pm, Eli Zaretskii wrote:

> 	* solib.c (solib_open): Use IS_DIR_SEPARATOR and IS_ABSOLUTE_PATH
> 	instead of SLASH_CHAR, ROOTED_P and SLASH_P.
> 	(top-level): #include "filenames.h".

Your changes to solib.c are approved.  (FWIW, I glanced over your
changes to the other files and they look good too.)

> 	* defs.h (SLASH_P, SLASH_CHAR, ROOTED_P): Remove definitions.
> 	(SLASH_STRING): Define only for _WIN32.

Once your changes to the other .c files are approved, I think this
one can be regarded as an obvious change.

Don't forget to also remove the definitions of SLASH_P, SLASH_CHAR, and
ROOTED_P in config/i386/xm-cygwin.h and config/i386/xm-go32.h.

Kevin

Follow-Ups:
- Re: [RFA] Remove OS-specific defines (was: _WIN32?)
  - From: Eli Zaretskii

References:
- Re: [Mingw-users] Re: _WIN32?
  - From: Danny Smith
- Re: [Mingw-users] Re: _WIN32?
  - From: Andrew Cagney
- [RFA] Remove OS-specific defines (was: _WIN32?)
  - From: Eli Zaretskii

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]