This is the mail archive of the gdb@sources.redhat.com mailing list for the GDB project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]

savestring()


Lint complaints about signed/unsigned conversions in the typical use
of savestring:

        x->foo = savestring(bar, strlen(bar));

Is there any reason why we shouldn't change the type of savestring's
(likewise msavestring) second argument from int to size_t?

Also, since the above is the same as:

        x->foo = xstrdup(bar);

Is there any reason why we shouldn't change it?  It's a bit odd that
half the code uses savestring() and the other half uses xstrdup().

        --jtc

-- 
J.T. Conklin
RedBack Networks


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]