This is the mail archive of the
gdb-testers@sourceware.org
mailing list for the GDB project.
[binutils-gdb] Sign-extend non-bit-fields in unpack_bits_as_long
- From: sergiodj+buildbot at sergiodj dot net
- To: gdb-testers at sourceware dot org
- Date: Mon, 26 Feb 2018 12:04:47 -0500
- Subject: [binutils-gdb] Sign-extend non-bit-fields in unpack_bits_as_long
- Authentication-results: sourceware.org; auth=none
*** TEST RESULTS FOR COMMIT 15ce8941e7d2807a3396a6874c528b24c387660a ***
Author: Tom Tromey <tom@tromey.com>
Branch: master
Commit: 15ce8941e7d2807a3396a6874c528b24c387660a
Sign-extend non-bit-fields in unpack_bits_as_long
unpack_bits_as_long is documented as sign-extending its result when
the type is signed. However, it was only doing sign-extension in the
case where the field was a bitfield -- that is, not when the "bitsize"
parameter was 0, indicating the size should be taken from the type.
Also, unpack_bits_as_long was incorrectly computing the shift for
big-endian architectures for the non-bitfield case.
This patch fixes these bugs in a straightforward way. A new selftest
is included.
2018-02-26 Tom Tromey <tom@tromey.com>
* Makefile.in (SUBDIR_UNITTESTS_SRCS): Add
unittests/unpack-selftests.c.
* unittests/unpack-selftests.c: New file.
* value.c (unpack_bits_as_long): Fix bugs in non-bitfield cases.