This is the mail archive of the
gdb-testers@sourceware.org
mailing list for the GDB project.
[binutils-gdb] dtrace-probe: Put semicolon after while on its own line
- From: sergiodj+buildbot at sergiodj dot net
- To: gdb-testers at sourceware dot org
- Date: Sun, 25 Jun 2017 07:40:52 -0400
- Subject: [binutils-gdb] dtrace-probe: Put semicolon after while on its own line
- Authentication-results: sourceware.org; auth=none
*** TEST RESULTS FOR COMMIT 07809eafc959a0c588663c0c949eaf8044a1b40a ***
Author: Simon Marchi <simon.marchi@ericsson.com>
Branch: master
Commit: 07809eafc959a0c588663c0c949eaf8044a1b40a
dtrace-probe: Put semicolon after while on its own line
clang shows this warning.
/home/emaisin/src/binutils-gdb/gdb/dtrace-probe.c:424:52: error: while loop has empty body [-Werror,-Wempty-body]
while (*p++ != '\0' && p - strtab < strtab_size);
^
/home/emaisin/src/binutils-gdb/gdb/dtrace-probe.c:424:52: note: put the semicolon on a separate line to silence this warning
Putting the semicolon on its own line is not a big sacrifice to get rid of this
warning. I think it's also useful to keep this, because it can catch errors
like this:
while (something);
{
...
}
although gcc would warn about it in a different way (misleading indentation).
This warning is already discussed here in the GCC bugzilla:
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=62184
gdb/ChangeLog:
* dtrace-probe.c (dtrace_process_dof_probe): Put semi-colon on
its own line.