This is the mail archive of the
gdb-testers@sourceware.org
mailing list for the GDB project.
[binutils-gdb] .gdb_index writer: close the file before unlinking it
- From: sergiodj+buildbot at sergiodj dot net
- To: gdb-testers at sourceware dot org
- Date: Mon, 19 Jun 2017 08:14:41 -0400
- Subject: [binutils-gdb] .gdb_index writer: close the file before unlinking it
- Authentication-results: sourceware.org; auth=none
*** TEST RESULTS FOR COMMIT 16b7a7199881fa26fc863279bbf08741e5674b5d ***
Author: Pedro Alves <palves@redhat.com>
Branch: master
Commit: 16b7a7199881fa26fc863279bbf08741e5674b5d
.gdb_index writer: close the file before unlinking it
We should close the file before unlinking because on MS-Windows one
cannot delete a file that is still open.
I considered making 'gdb::unlinker::unlinker(const char *)'
'noexcept(true)' and then adding
static_assert (noexcept (gdb::unlinker (filename.c_str ())), "");
but that doesn't really work because gdb::unlinker has a gdb_assert,
which can throw a QUIT if/when the assertion fails. 'noexcept(true)'
would cause GDB to abruptly terminate if/when the assertion fails.
gdb/ChangeLog:
2017-06-19 Pedro Alves <palves@redhat.com>
* dwarf2read.c (write_psymtabs_to_index): Construct file_closer
after gdb::unlinker.