This is the mail archive of the
gdb-testers@sourceware.org
mailing list for the GDB project.
[binutils-gdb] read/write_pieced_value: Remove unnecessary variable copies
- From: sergiodj+buildbot at sergiodj dot net
- To: gdb-testers at sourceware dot org
- Date: Tue, 13 Jun 2017 16:51:12 -0400
- Subject: [binutils-gdb] read/write_pieced_value: Remove unnecessary variable copies
- Authentication-results: sourceware.org; auth=none
*** TEST RESULTS FOR COMMIT f236533e3c6a2693bea879b2a4d24d1229864ac9 ***
Author: Andreas Arnez <arnez@linux.vnet.ibm.com>
Branch: master
Commit: f236533e3c6a2693bea879b2a4d24d1229864ac9
read/write_pieced_value: Remove unnecessary variable copies
In read_pieced_value's main loop, the variables `dest_offset_bits' and
`source_offset_bits' are basically just copies of `offset' and
`bits_to_skip', respectively. In write_pieced_value the copies are
reversed. This is not very helpful when trying to keep the logic between
these functions in sync. Since the copies are unnecessary, this patch
just removes them.
gdb/ChangeLog:
* dwarf2loc.c (read_pieced_value): Remove unnecessary variables
dest_offset_bits and source_offset_bits.
(write_pieced_value): Likewise.