This is the mail archive of the
gdb-testers@sourceware.org
mailing list for the GDB project.
[binutils-gdb] Use disassemble.c:disassembler select rs6000 disassembler
- From: sergiodj+buildbot at sergiodj dot net
- To: gdb-testers at sourceware dot org
- Date: Wed, 24 May 2017 14:49:16 -0400
- Subject: [binutils-gdb] Use disassemble.c:disassembler select rs6000 disassembler
- Authentication-results: sourceware.org; auth=none
*** TEST RESULTS FOR COMMIT f4985dba0f53b38efcca4eef42cfbfca5ef44ee2 ***
Author: Yao Qi <yao.qi@linaro.org>
Branch: master
Commit: f4985dba0f53b38efcca4eef42cfbfca5ef44ee2
Use disassemble.c:disassembler select rs6000 disassembler
Nowadays, rs6000 disassembler is selected in different ways in
opcodes and gdb,
opcodes:
case bfd_arch_rs6000:
if (mach == bfd_mach_ppc_620)
disassemble = print_insn_big_powerpc;
else
disassemble = print_insn_rs6000;
break;
gdb:
if (arch == bfd_arch_rs6000)
set_gdbarch_print_insn (gdbarch, print_insn_rs6000);
else
set_gdbarch_print_insn (gdbarch, gdb_print_insn_powerpc);
I am not sure which one is the right one. However, such selection
should be done in one place instead of two.
gdb:
2017-05-24 Yao Qi <yao.qi@linaro.org>
* rs6000-tdep.c (gdb_print_insn_powerpc): Remove.
(rs6000_gdbarch_init): Don't call set_gdbarch_print_insn.