[binutils-gdb] Use scoped_value_mark in dwarf2_evaluate_loc_desc_full

[sergiodj+buildbot at sergiodj dot net]

*** TEST RESULTS FOR COMMIT 0cf082277804ba3747be70a4013019f68b92bb84 ***

Author: Tom Tromey <tom@tromey.com>
Branch: master
Commit: 0cf082277804ba3747be70a4013019f68b92bb84

Use scoped_value_mark in dwarf2_evaluate_loc_desc_full

This changes dwarf2_evaluate_loc_desc_full to use scoped_value_mark.

Note that this function previously called do_cleanup using the same
cleanup multiple times.  I had thought this was buggy, but re-reading
make_my_cleanup2 indicates that it is not.  Nevertheless it is
surprising, and at least one of the calls (the one that is completely
removed in this patch) seems to have been done under the assumption
that it would still have some effect.

2017-01-10  Tom Tromey  <tom@tromey.com>

	* value.h (scoped_value_mark::~scoped_value_mark): Call
	free_to_mark.
	(scoped_value_mark::free_to_mark): New method.
	* dwarf2loc.c (dwarf2_evaluate_loc_desc_full): Use
	scoped_value_mark.