This is the mail archive of the
gdb-testers@sourceware.org
mailing list for the GDB project.
[binutils-gdb] libiberty: Fix -Wimplicit-fallthrough warnings.
- From: sergiodj+buildbot at sergiodj dot net
- To: gdb-testers at sourceware dot org
- Date: Fri, 18 Nov 2016 11:06:10 -0500
- Subject: [binutils-gdb] libiberty: Fix -Wimplicit-fallthrough warnings.
- Authentication-results: sourceware.org; auth=none
*** TEST RESULTS FOR COMMIT 4d17eaece8b31e642acaf4d77fe961ad8e3aaf50 ***
Author: Mark Wielaard <mjw@redhat.com>
Branch: master
Commit: 4d17eaece8b31e642acaf4d77fe961ad8e3aaf50
libiberty: Fix -Wimplicit-fallthrough warnings.
Adjust some comments, add some explicit fall through comments or explicit
returns where necessary to not get implicit-fallthrough warnings.
All fall throughs were deliberate. In one case I added an explicit return
false for clarity instead of falling through a default case (that also
would return false).
libiberty/ChangeLog:
* cplus-dem.c (demangle_signature): Move fall through comment.
(demangle_fund_type): Add fall through comment between 'G' and 'I'.
* hashtab.c (iterative_hash): Add fall through comments.
* regex.c (regex_compile): Add Fall through comment after '+'/'?'.
(byte_re_match_2_internal): Add Fall through comment after jump_n.
Change "Note fall through" to "Fall through".
(common_op_match_null_string_p): Return false after set_number_at
instead of fall through.