This is the mail archive of the
gdb-testers@sourceware.org
mailing list for the GDB project.
[binutils-gdb/gdb-7.12-branch] x32: Avoid unsigned long when installing fast tracepoint jump pads
- From: sergiodj+buildbot at sergiodj dot net
- To: gdb-testers at sourceware dot org
- Date: Tue, 23 Aug 2016 20:08:01 -0400
- Subject: [binutils-gdb/gdb-7.12-branch] x32: Avoid unsigned long when installing fast tracepoint jump pads
- Authentication-results: sourceware.org; auth=none
*** TEST RESULTS FOR COMMIT 53e8498437380263d5321bf841c6de526e676347 ***
Author: Pedro Alves <palves@redhat.com>
Branch: gdb-7.12-branch
Commit: 53e8498437380263d5321bf841c6de526e676347
x32: Avoid unsigned long when installing fast tracepoint jump pads
We're casting through unsigned long to write a 64-bit immediate
operand of movabs (the comment said movl, but that was incorrect).
The problem is that unsigned long is 32-bit on x32, so we were writing
fewer bytes than necessary.
Fix this by using an 8 byte memcpy like in other similar places in the
function.
gdb/gdbserver/ChangeLog:
2016-08-23 Pedro Alves <palves@redhat.com>
* linux-x86-low.c (amd64_install_fast_tracepoint_jump_pad): Fix
comment. Use memcpy instead of casting through unsigned long.
- Follow-Ups:
- Failures on Fedora-x86_64-native-gdbserver-m32, branch gdb-7.12-branch
- Failures on Fedora-x86_64-m32, branch gdb-7.12-branch
- Failures on Fedora-x86_64-native-extended-gdbserver-m32, branch gdb-7.12-branch
- Failures on Fedora-x86_64-native-gdbserver-m64, branch gdb-7.12-branch
- Failures on Fedora-i686, branch gdb-7.12-branch
- Failures on Fedora-x86_64-m64, branch gdb-7.12-branch
- Failures on Fedora-x86_64-cc-with-index, branch gdb-7.12-branch
- Failures on Debian-s390x-native-extended-gdbserver-m64, branch gdb-7.12-branch
- Failures on Fedora-s390x-m64, branch gdb-7.12-branch
- Failures on Debian-i686, branch gdb-7.12-branch
- Failures on Debian-i686-native-extended-gdbserver, branch gdb-7.12-branch
- Failures on Fedora-ppc64be-native-gdbserver-m64, branch gdb-7.12-branch
- Failures on Fedora-ppc64be-native-extended-gdbserver-m64, branch gdb-7.12-branch
- Failures on Fedora-ppc64le-native-extended-gdbserver-m64, branch gdb-7.12-branch
- Failures on Debian-x86_64-m64, branch gdb-7.12-branch
- Failures on Debian-x86_64-native-extended-gdbserver-m64, branch gdb-7.12-branch