This is the mail archive of the
gdb-testers@sourceware.org
mailing list for the GDB project.
[binutils-gdb/gdb-7.12-branch] Fix PR gdb/19187 (process record over a fork causes internal error)
- From: sergiodj+buildbot at sergiodj dot net
- To: gdb-testers at sourceware dot org
- Date: Wed, 10 Aug 2016 21:14:53 -0400
- Subject: [binutils-gdb/gdb-7.12-branch] Fix PR gdb/19187 (process record over a fork causes internal error)
- Authentication-results: sourceware.org; auth=none
*** TEST RESULTS FOR COMMIT 4dfacf706adacbefbc38d7ba59212566f77bd051 ***
Author: Pedro Alves <palves@redhat.com>
Branch: gdb-7.12-branch
Commit: 4dfacf706adacbefbc38d7ba59212566f77bd051
Fix PR gdb/19187 (process record over a fork causes internal error)
Right after a fork is detected, we detach breakpoints from the child
(detach_breakpoints), which calls into target_remove_breakpoint with
inferior_ptid pointing at the child process, but leaves the breakpoint
marked inserted (in the parent).
The problem is that record-full.c always deletes all knowledge of the
breakpoint. Then when we later really delete the breakpoint from the
parent, we fail the assertion, since the breakpoint is unexpectedly
not found in the record-full.c breakpoint table.
The fix is simply to not forget about the breakpoint if we're
detaching it from a fork child.
gdb/ChangeLog:
2016-08-10 Pedro Alves <palves@redhat.com>
PR gdb/19187
* record-full.c (record_full_remove_breakpoint): Don't remove the
breakpoint from the record_full_breakpoints VEC if we're detaching
the breakpoint from a fork child.
gdb/testsuite/ChangeLog:
2016-08-10 Pedro Alves <palves@redhat.com>
PR gdb/19187
* gdb.reverse/waitpid-reverse.exp: Add comment and remove
setup_kfails.
- Follow-Ups:
- Failures on Fedora-x86_64-native-gdbserver-m32, branch gdb-7.12-branch
- Failures on Fedora-x86_64-native-extended-gdbserver-m32, branch gdb-7.12-branch
- Failures on Fedora-x86_64-m32, branch gdb-7.12-branch
- Failures on Fedora-i686, branch gdb-7.12-branch
- Failures on Fedora-x86_64-cc-with-index, branch gdb-7.12-branch
- Failures on Debian-s390x-native-gdbserver-m64, branch gdb-7.12-branch
- Failures on Debian-s390x-m64, branch gdb-7.12-branch
- Failures on Debian-s390x-native-extended-gdbserver-m64, branch gdb-7.12-branch
- Failures on Debian-i686, branch gdb-7.12-branch
- Failures on Debian-i686-native-extended-gdbserver, branch gdb-7.12-branch
- Failures on Fedora-s390x-m64, branch gdb-7.12-branch
- Failures on Debian-x86_64-native-extended-gdbserver-m64, branch gdb-7.12-branch
- Failures on Fedora-ppc64be-m64, branch gdb-7.12-branch
- Failures on Fedora-ppc64be-native-gdbserver-m64, branch gdb-7.12-branch
- Failures on Fedora-ppc64le-native-extended-gdbserver-m64, branch gdb-7.12-branch
- Failures on Fedora-ppc64be-native-extended-gdbserver-m64, branch gdb-7.12-branch
- Failures on Fedora-ppc64le-native-gdbserver-m64, branch gdb-7.12-branch