This is the mail archive of the
gdb-testers@sourceware.org
mailing list for the GDB project.
[binutils-gdb] Fix PR remote/20398: File-IO write always outputs "Quit"
- From: sergiodj+buildbot at sergiodj dot net
- To: gdb-testers at sourceware dot org
- Date: Fri, 05 Aug 2016 15:40:51 -0400
- Subject: [binutils-gdb] Fix PR remote/20398: File-IO write always outputs "Quit"
- Authentication-results: sourceware.org; auth=none
*** TEST RESULTS FOR COMMIT 3906a8fc773a405b511faed030e4630ecbd4b8a9 ***
Author: Pedro Alves <palves@redhat.com>
Branch: master
Commit: 3906a8fc773a405b511faed030e4630ecbd4b8a9
Fix PR remote/20398: File-IO write always outputs "Quit"
Commit bb7c96deb1a1 ("gdb/remote-fileio.c: Eliminate custom SIGINT
signal handler") regressed the File-IO support.
Failed output:
(gdb) target remote :8888
Remote debugging using :8888
0x00008098 in _start ()
(gdb) c
Continuing.
Quit
Quit
Quit
Quit
Quit
Quit
Quit
Quit
Quit
Quit
Quit
[Inferior 1 (Remote target) exited normally]
Expected output:
(gdb) target remote :8888
Remote debugging using :8888
0x00008098 in _start ()
(gdb) c
Continuing.
i: 0
i: 1
i: 2
i: 3
i: 4
i: 5
i: 6
i: 7
i: 8
i: 9
[Inferior 1 (Remote target) exited normally]
The problem that the new File-IO quit handler forgets to check the
quit flag before calling throwing a quit.
gdb/ChangeLog:
2016-08-05 Pedro Alves <palves@redhat.com>
PR remote/20398
* remote-fileio.c (remote_fileio_quit_handler): Check the quit
flag before calling quit.
- Follow-Ups:
- *** COMPILATION FAILED *** Failures on Debian-s390x-native-gdbserver-m64, branch master *** BREAKAGE ***
- Failures on Debian-s390x-m64, branch master
- Failures on Fedora-x86_64-m32, branch master
- Failures on Debian-s390x-native-extended-gdbserver-m64, branch master
- Failures on Debian-i686-native-extended-gdbserver, branch master
- Failures on Debian-x86_64-native-extended-gdbserver-m64, branch master
- Failures on Fedora-ppc64be-m64, branch master
- Failures on Fedora-ppc64be-native-gdbserver-m64, branch master
- Failures on Fedora-ppc64be-native-extended-gdbserver-m64, branch master
- Failures on Fedora-ppc64le-native-extended-gdbserver-m64, branch master
- Failures on Fedora-ppc64le-cc-with-index, branch master
- Failures on Fedora-ppc64le-native-gdbserver-m64, branch master