[Bug gdb/24669] index-cache.exp FAILs with -readnow

[cvs-commit at gcc dot gnu.org]

https://sourceware.org/bugzilla/show_bug.cgi?id=24669

--- Comment #3 from cvs-commit at gcc dot gnu.org <cvs-commit at gcc dot gnu.org> ---
The master branch has been updated by Simon Marchi <simark@sourceware.org>:

https://sourceware.org/git/gitweb.cgi?p=binutils-gdb.git;h=399aaebd1a5e9e3971758396bd0c5c3ec5ae2386

commit 399aaebd1a5e9e3971758396bd0c5c3ec5ae2386
Author: Simon Marchi <simon.marchi@polymtl.ca>
Date:   Sun Jun 16 09:07:16 2019 -0400

    Make gdb.base/index-cache.exp work with readnow board (PR 24669)

    The gdb.base/index-cache.exp test fails with the readnow board:

      $ make check TESTS="gdb.base/index-cache.exp"
RUNTESTFLAGS="--target_board=readnow"
      FAIL: gdb.base/index-cache.exp: test_cache_enabled_miss: at least one
file was created
      FAIL: gdb.base/index-cache.exp: test_cache_enabled_miss: expected file is
there
      FAIL: gdb.base/index-cache.exp: test_cache_enabled_miss: check
index-cache stats
      FAIL: gdb.base/index-cache.exp: test_cache_enabled_hit: check index-cache
stats

    The problem is similar to what was fixed in

      5a56d6a65f84 ("[gdb/testsuite] Fix index-cache.exp with
cc-with-{gdb-index,debug-names}")

    In that commit, gdb.base/index-cache.exp was modified to account for the
    fact that the index cache is not used when the binary already has an
    embedded index.

    The same situation happens when GDB is started with the -readnow flag:
    it bypasses indices and partial symbols.  So this patch updates the test
    to also expect the index cache not to be used if -readnow is present in
    $GDBFLAGS,

    gdb/testsuite/ChangeLog:

        PR gdb/24669
        * gdb.base/index-cache.exp (uses_readnow,
        expecting_index_cache_use): Define global variable.
        (test_cache_enabled_miss, test_cache_enabled_hit): Use
        expecting_index_cache_use.

-- 
You are receiving this mail because:
You are on the CC list for the bug.