This is the mail archive of the gdb-prs@sourceware.org mailing list for the GDB project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

[Bug gdb/22670] regressions in Ada caused by introduction of wild matching in C++ patch series


https://sourceware.org/bugzilla/show_bug.cgi?id=22670

--- Comment #11 from cvs-commit at gcc dot gnu.org <cvs-commit at gcc dot gnu.org> ---
The master branch has been updated by Pedro Alves <palves@sourceware.org>:

https://sourceware.org/git/gitweb.cgi?p=binutils-gdb.git;h=8825213e97f0476068dc3b52b1b61df96b40708a

commit 8825213e97f0476068dc3b52b1b61df96b40708a
Author: Pedro Alves <palves@redhat.com>
Date:   Wed Jan 10 20:38:06 2018 +0000

    Fix gdb.ada/bp_c_mixed_case.exp (PR gdb/22670)

    The problem here is that we are using the user-provided lookup name
    literally for name comparisons.  I.e., "<MixedCase>" with the "<>"s
    included.

    This commit fixes the minsym lookup case.  psymbol/symbol lookup will
    be fixed in a follow up.

    In the minsym case, we're using using the user-provided lookup name
    literally for linkage name comparisons.  That obviously can't work
    since the "<>" are not really part of the linkage name.

    The original idea was that we'd use the symbol's language to select
    the right symbol name matching algorithm, but that doesn't work for
    Ada because it's not really possible to unambiguously tell from the
    linkage name alone whether we're dealing with Ada symbols, so Ada
    minsyms end up with no language set, or sometimes C++ set.

    So fix this by treating Ada mode specially when determining the
    linkage name to match against.

    gdb/ChangeLog:
    2018-01-10  Pedro Alves  <palves@redhat.com>

        PR gdb/22670
        * minsyms.c (linkage_name_str): New function.
        (iterate_over_minimal_symbols): Use it.

    gdb/testsuite/ChangeLog:
    2018-01-10  Pedro Alves  <palves@redhat.com>

        PR gdb/22670
        * gdb.ada/bp_c_mixed_case.exp: Remove setup_kfail calls.

-- 
You are receiving this mail because:
You are on the CC list for the bug.

Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]