[Bug gdb/22670] regressions in Ada caused by introduction of wild matching in C++ patch series

["cvs-commit at gcc dot gnu.org" <sourceware-bugzilla at sourceware dot org>]

https://sourceware.org/bugzilla/show_bug.cgi?id=22670

--- Comment #5 from cvs-commit at gcc dot gnu.org <cvs-commit at gcc dot gnu.org> ---
The master branch has been updated by Pedro Alves <palves@sourceware.org>:

https://sourceware.org/git/gitweb.cgi?p=binutils-gdb.git;h=f98fc17b3ac4750842ec0fe28a18b51691ddfbda

commit f98fc17b3ac4750842ec0fe28a18b51691ddfbda
Author: Pedro Alves <palves@redhat.com>
Date:   Fri Jan 5 16:01:57 2018 +0000

    Fix gdb.ada/info_addr_mixed_case.exp (PR gdb/22670)

    The comments about mixed case in the testcase are actually a red
    herring.  The problem here is that we'd get to
    ada_lookup_encoded_symbol with "my_table", which wraps the looked up
    name in "<>"s to force a verbatim match, and that in turn disables
    wild matching.

    Fix this by swapping around the internals of ada_lookup_encoded_symbol
    and ada_lookup_symbol, thus avoiding the encoding and
    verbatim-wrapping in the ada_lookup_symbol case, the case that starts
    with a user-provided lookup name.

    Ada encoding is still done of course, in the ada_lookup_name_info
    ctor.  This could be also seen as avoiding the double-encoding problem
    in a different way.

    gdb/ChangeLog:
    2018-01-05  Pedro Alves  <palves@redhat.com>

        PR gdb/22670
        * ada-lang.c (ada_lookup_encoded_symbol): Reimplement in terms of
        ada_lookup_symbol.
        (ada_lookup_symbol): Reimplement in terms of
        ada_lookup_symbol_list, bits factored out from
        ada_lookup_encoded_symbol.

    gdb/testsuite/ChangeLog:
    2018-01-05  Pedro Alves  <palves@redhat.com>

        PR gdb/22670
        * gdb.ada/info_addr_mixed_case.exp: Remove kfail.  Extend test to
        exercise lower case too, and to exercise both full matching and
        wild matching.

-- 
You are receiving this mail because:
You are on the CC list for the bug.