This is the mail archive of the gdb-prs@sourceware.org mailing list for the GDB project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

[Bug breakpoints/22567] pending breakpoint location's gdbarch is incorrect after it is resolved


https://sourceware.org/bugzilla/show_bug.cgi?id=22567

--- Comment #3 from cvs-commit at gcc dot gnu.org <cvs-commit at gcc dot gnu.org> ---
The master branch has been updated by Yao Qi <qiyao@sourceware.org>:

https://sourceware.org/git/gitweb.cgi?p=binutils-gdb.git;h=6b05c8bd437152d7a3ecfc19074ab243ee6c92f2

commit 6b05c8bd437152d7a3ecfc19074ab243ee6c92f2
Author: Yao Qi <yao.qi@linaro.org>
Date:   Fri Dec 8 15:43:49 2017 +0000

    Fix PR 22567: set SAL .section in minsym_found

    PR 22567 is that breakpoint location can't correct gdbarch from SAL,
    because its fields .section and .symtab is NULL.  We use to have code
    setting .section, but was removed by 4024cf2

    -  if (msymbol_is_text (msymbol))
    +  CORE_ADDR func_addr;
    +  if (msymbol_is_function (objfile, msymbol, &func_addr))
         {
    -      sal = find_pc_sect_line (MSYMBOL_VALUE_ADDRESS (objfile, msymbol),
    -                              (struct obj_section *) 0, 0);
    -      sal.section = MSYMBOL_OBJ_SECTION (objfile, msymbol);

    this patch adds this back by moving it to the common place at the bottom
    of the function.

    gdb:

    2017-12-08  Yao Qi  <yao.qi@linaro.org>

        PR breakpionts/22567
        * linespec.c (minsym_found): Set sal.section.

-- 
You are receiving this mail because:
You are on the CC list for the bug.

Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]