[Bug breakpoints/21886] Compressed MIPS code debugging impossible due to memory breakpoint misplacement

["cvs-commit at gcc dot gnu.org" <sourceware-bugzilla at sourceware dot org>]

https://sourceware.org/bugzilla/show_bug.cgi?id=21886

--- Comment #2 from cvs-commit at gcc dot gnu.org <cvs-commit at gcc dot gnu.org> ---
The gdb-8.0-branch branch has been updated by Maciej W. Rozycki
<macro@sourceware.org>:

https://sourceware.org/git/gitweb.cgi?p=binutils-gdb.git;h=b3e687f4c5e2bd847ea0608fd8960820f3efbda3

commit b3e687f4c5e2bd847ea0608fd8960820f3efbda3
Author: Maciej W. Rozycki <macro@imgtec.com>
Date:   Fri Aug 11 10:40:06 2017 +0100

    PR breakpoints/21886: mem-break: Fix breakpoint insertion location

    Fix a commit cd6c3b4ffc4e ("New gdbarch methods breakpoint_kind_from_pc
    and sw_breakpoint_from_kind") regression and restore the use of
    `->placed_address' rather than `->reqstd_address' as the location for a
    memory breakpoint to be inserted at.  Previously
    `gdbarch_breakpoint_from_pc' was used that made that adjustment in
    `default_memory_insert_breakpoint' from the preinitialized value,
    however with the said commit that call is gone, so the passed
    `->placed_address' has to be used for the initialization.

    The regression manifests itself as the inability to debug any MIPS/Linux
    compressed ISA dynamic executable as GDB corrupts the dynamic loader
    with one of its implicit breakpoints, causing the program to crash, as
    seen for example with the `mips-linux-gnu' target, o32 ABI, MIPS16 code,
    and the gdb.base/advance.exp test case:

    (gdb) continue
    Continuing.

    Program received signal SIGBUS, Bus error.
    _dl_debug_initialize (ldbase=0, ns=0) at dl-debug.c:51
    51      r = &_r_debug;
    (gdb) FAIL: gdb.base/advance.exp: Can't run to main

        gdb/
        PR breakpoints/21886
        * mem-break.c (default_memory_insert_breakpoint): Use
        `->placed_address' rather than `->reqstd_address' for the
        breakpoint location.

    (cherry picked from commit ba7b109b296feac8cf8cab74db5f824dfa631610)

-- 
You are receiving this mail because:
You are on the CC list for the bug.