[Bug gdb/20663] build-id.c : should not do sign-extension on first byte of ID to form names like .../.build-id/ffffff88/.... from 0x88 !

["tromey at sourceware dot org" <sourceware-bugzilla at sourceware dot org>]

https://sourceware.org/bugzilla/show_bug.cgi?id=20663

Tom Tromey <tromey at sourceware dot org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|UNCONFIRMED                 |RESOLVED
                 CC|                            |tromey at sourceware dot org
         Resolution|---                         |INVALID

--- Comment #1 from Tom Tromey <tromey at sourceware dot org> ---
I don't see how this bug could happen here with git gdb.
"data" has type "gdb_byte *" -- and gdb_byte is an unsigned char.

I think instead the problem is probably caused by your patch,
which adds:

      char byte_1='\0';
...
          s += sprintf (s, "%02hhx", (byte_1 = *data++));

... but this assignment changes the type of the argument.

I'm closing as invalid on this basis; but please comment if
you think something is incorrect or if you can reproduce
the problem with an unmodified gdb.  I will reopen the bug in that
case.

-- 
You are receiving this mail because:
You are on the CC list for the bug.