[Bug breakpoints/18303] Assertation: -breakpoint-insert with windows paths of file in non-current directory

["cvs-commit at gcc dot gnu.org" <sourceware-bugzilla at sourceware dot org>]

https://sourceware.org/bugzilla/show_bug.cgi?id=18303

--- Comment #7 from cvs-commit at gcc dot gnu.org <cvs-commit at gcc dot gnu.org> ---
The master branch has been updated by Don Breazeal <donb@sourceware.org>:

https://sourceware.org/git/gitweb.cgi?p=binutils-gdb.git;h=1cafadb4e4eb329dea01355c6632b3077113d80c

commit 1cafadb4e4eb329dea01355c6632b3077113d80c
Author: Don Breazeal <donb@codesourcery.com>
Date:   Tue Mar 15 15:18:28 2016 -0700

    PR 18303, Tolerate malformed input for lookup_symbol-called functions

    lookup_symbol is often called with user input.  Consequently, any
    function called from lookup_symbol{,_in_language} should attempt to
    deal with malformed input gracefully.  After all, malformed user
    input is not a programming/API error.

    This patch does not attempt to find/correct all instances of this.  It
    only fixes locations in the code that trigger test suite failures.

    This patch fixes PR breakpoints/18303, "Assertion: -breakpoint-insert
    with windows paths of file in non-current directory".

    The patch includes three new tests related to this.  One is just
    gdb.linespec/ls-errs.exp copied and converted to use C++ instead of C, and
    to add a case using a file name containing a Windows-style logical drive
    specifier.  The others include an MI test to provide a regression test for
    the specific case reported in PR 18303, and a C++ test for proper error
    handling of access to a program variable when using a file scope specifier
    that refers to a non-existent file.

    Tested on x86_64 native Linux.

    gdb/ChangeLog
    2016-01-28  Keith Seitz  <keiths@redhat.com>

        PR breakpoints/18303
        * cp-namespace.c (cp_lookup_bare_symbol): Change assertion to
        look for "::" instead of simply ":".
        (cp_search_static_and_baseclasses): Return null_block_symbol for
        malformed input.
        Remove assertions.
        * cp-support.c (cp_find_first_component_aux): Do not return
        a prefix length for ':' unless the next character is also ':'.

    gdb/testsuite/ChangeLog
    2016-01-28  Don Breazeal  <donb@codesourcery.com>

        * gdb.cp/scope-err.cc: New test program.
        * gdb.cp/scope-err.exp: New test script.
        * gdb.linespec/ls-errs.c (myfunction): Expanded to have multiple
        lines and "set breakpoint here" comment.
        * gdb.linespec/ls-errs.exp: Added C++ testing and new test case.
        Fixed some whitespace and format issues.
        * gdb.mi/mi-linespec-err-cp.cc: New test program.
        * gdb.mi/mi-linespec-err-cp.exp: New test script.

-- 
You are receiving this mail because:
You are on the CC list for the bug.