[Bug sim/19309] New: src/sim/aarch64/simulator.c: two bugs ?

["dcb314 at hotmail dot com" <sourceware-bugzilla at sourceware dot org>]

https://sourceware.org/bugzilla/show_bug.cgi?id=19309

            Bug ID: 19309
           Summary: src/sim/aarch64/simulator.c: two bugs ?
           Product: gdb
           Version: HEAD
            Status: NEW
          Severity: normal
          Priority: P2
         Component: sim
          Assignee: unassigned at sourceware dot org
          Reporter: dcb314 at hotmail dot com
                CC: vapier at gentoo dot org
  Target Milestone: ---

1.

[src/sim/aarch64/simulator.c:10922] -> [src/sim/aarch64/simulator.c:10922]:
(style) Same expression on both sides of '&&'.

Source code is

 if (type != 0xE && type != 0xE && uimm (aarch64_get_instr (cpu), 21, 21) != 0)
    HALT_NYI;

Might be a typo or maybe redundant code.

2.

[src/sim/aarch64/simulator.c:2910] -> [src/sim/aarch64/simulator.c:2914]:
(warning) Variable 'val1' is reassigned a value before the old one has been
used. 'break;' missing?

    case 2:
      val1 = ((input1 & 0xFFFFFFFF) | ((input1 >> 32) &
0xFFFFFFFF00000000ULL));
      val2 = ((input2 & 0xFFFFFFFF) | ((input2 >> 32) &
0xFFFFFFFF00000000ULL));

    case 3:

-- 
You are receiving this mail because:
You are on the CC list for the bug.