This is the mail archive of the
gdb-prs@sourceware.org
mailing list for the GDB project.
[Bug testsuite/18704] Don't run bigcore test by default on make check
- From: "palves at redhat dot com" <sourceware-bugzilla at sourceware dot org>
- To: gdb-prs at sourceware dot org
- Date: Sun, 02 Aug 2015 13:56:56 +0000
- Subject: [Bug testsuite/18704] Don't run bigcore test by default on make check
- Auto-submitted: auto-generated
- References: <bug-18704-4717 at http dot sourceware dot org/bugzilla/>
https://sourceware.org/bugzilla/show_bug.cgi?id=18704
--- Comment #7 from Pedro Alves <palves at redhat dot com> ---
(In reply to Ciro Santilli from comment #4)
> I don't know if it is technically feasible for apport to generate the sparse
> dump.
Can't see why not.
(In reply to Doug Evans from comment #6)
> Fedora uses abrt which introduces a similar problem.
> $ cat /proc/sys/kernel/core_pattern
> |/usr/libexec/abrt-hook-ccpp %s %c %p %u %g %t %e %i
AFAICS from the sources, abrt should be creating sparse cores:
https://github.com/abrt/abrt/blob/master/src/hooks/abrt-hook-ccpp.c
Funny enough, they even have a test specifically to make sure that
gdb's bigcore test doesn't run slower with abrt:
https://github.com/abrt/abrt/tree/master/tests/runtests/bz591504-sparse-core-files-performance-hit
> I think this is a problem that needs to be solved,
> and I'm ok with system-specific checks.
We can also detect if the system generates sparse cores, with
du --apparent-size (naturally gracefully handling the case
of "du --apparent" failing). That is, generate a smaller core
with zeros in it, check if it is sparse, and if not, skip the big
test.
> Adding them on a per-test basis gets cumbersome though,
> there may be only one big core test today but
> even other core tests get slowed down.
> And there are a plethora of attach tests and
> we don't want to have to edit and maintain such
> checks in every one of them.
We already have to do:
if {![can_spawn_for_attach]} {
return 0
}
On "attach" tests. We can put more checks inside that function (and rename
it if it makes sense).
>
> What I do is perform a collection of sanity checks
> up front, before real testing starts.
I think that'd be nice too.
--
You are receiving this mail because:
You are on the CC list for the bug.