This is the mail archive of the gdb-prs@sourceware.org mailing list for the GDB project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

[Bug record/18691] Regression in solib-precsave.exp


https://sourceware.org/bugzilla/show_bug.cgi?id=18691

--- Comment #2 from cvs-commit at gcc dot gnu.org <cvs-commit at gcc dot gnu.org> ---
The master branch has been updated by Yao Qi <qiyao@sourceware.org>:

https://sourceware.org/git/gitweb.cgi?p=binutils-gdb.git;h=cc9f16aa882eb22cb2128c5eb8237fd453ab2988

commit cc9f16aa882eb22cb2128c5eb8237fd453ab2988
Author: Yao Qi <yao.qi@linaro.org>
Date:   Wed Jul 29 12:43:10 2015 +0100

    PR record/18691: Fix fails in solib-precsave.exp

    We see the following regressions in testing on x86_64-linux,

     reverse-step^M
     Cannot access memory at address 0x2aaaaaed26c0^M
     (gdb) FAIL: gdb.reverse/solib-precsave.exp: reverse-step into solib
function one

    when GDB reverse step into a function, GDB wants to skip prologue so
    it requests TARGET_OBJECT_CODE_MEMORY to read some code memory in
    memory_xfer_partial_1.  However in dcache_read_memory_partial, the object
    becomes TARGET_OBJECT_MEMORY

          return ops->to_xfer_partial (ops, TARGET_OBJECT_MEMORY, NULL,
                                       myaddr, NULL, memaddr, len,
                                       xfered_len);

    in reverse debugging, ops->to_xfer_partial is record_full_core_xfer_partial
    and it will return TARGET_XFER_E_IO because it can't find any records.
    The test fails.

    At this moment, the delegate relationship is like

      dcache -> record-core -> core -> exec

    and we want to GDB read memory across targets, which means if the
    requested memory isn't found in record-core, GDB can read memory from
    core, and exec even further if needed.  I find raw_memory_xfer_partial
    is exactly what I want.

    gdb:

    2015-07-29  Yao Qi  <yao.qi@linaro.org>

        PR record/18691
        * dcache.c (dcache_read_memory_partial): Call
        raw_memory_xfer_partial.
        * target.c (raw_memory_xfer_partial): Make it non-static.
        * target.h (raw_memory_xfer_partial): Declare.

-- 
You are receiving this mail because:
You are on the CC list for the bug.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]