This is the mail archive of the gdb-prs@sourceware.org mailing list for the GDB project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

[Bug gdb/18155] gdb TUI SEGVs when resizing asm window


https://sourceware.org/bugzilla/show_bug.cgi?id=18155

--- Comment #1 from cvs-commit at gcc dot gnu.org <cvs-commit at gcc dot gnu.org> ---
The master branch has been updated by Patrick Palka <ppalka@sourceware.org>:

https://sourceware.org/git/gitweb.cgi?p=binutils-gdb.git;h=9720679936fc4f710d718f13d903c7826e048a36

commit 9720679936fc4f710d718f13d903c7826e048a36
Author: Patrick Palka <patrick@parcs.ath.cx>
Date:   Sat Apr 25 21:59:02 2015 -0400

    Fix PR gdb/18155

    For no good reason the function tui_free_window() is freeing the locator
    window when we pass it an SRC_WIN or a DISASSEM_WIN.  This behavior
    doesn't make much sense because the locator window is always visible and
    its contents do not change when the main window changes.

    This behavior triggers the above PR because when we switch from one TUI
    window to another (in the PR, from the src window to the asm window) we
    call tui_free_window() on the previously active window (in the PR, the
    src window).  The function then frees the src window along with the
    locator window and later we segfault when the now-active asm window
    tries to query the locator window about the inferior's PC.

    This patch fixes this apparently wrong behavior by changing
    tui_free_window() to not free the locator window when we pass it an
    SRC_WIN or a DISASSEM_WIN.

    gdb/ChangeLog:

        PR gdb/18155
        * tui/tui-data.c (tui_free_window): Don't free the locator
        window when passed an SRC_WIN or a DISASSEM_WIN.

-- 
You are receiving this mail because:
You are on the CC list for the bug.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]