This is the mail archive of the gdb-prs@sourceware.org mailing list for the GDB project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

[Bug python/17234] New: unused variables in py-framefilter.c


https://sourceware.org/bugzilla/show_bug.cgi?id=17234

            Bug ID: 17234
           Summary: unused variables in py-framefilter.c
           Product: gdb
           Version: HEAD
            Status: NEW
          Severity: normal
          Priority: P2
         Component: python
          Assignee: unassigned at sourceware dot org
          Reporter: tromey at redhat dot com

Compiling with -Wunused-but-set-variable shows a couple
of oddities in py-framefilter.c:

../../binutils-gdb/gdb/python/py-framefilter.c: In function âpy_print_typeâ:
../../binutils-gdb/gdb/python/py-framefilter.c:209:20: error: variable âtypeâ
set but not used [-Werror=unused-but-set-variable]
       struct type *type;
                    ^
../../binutils-gdb/gdb/python/py-framefilter.c: In function âpy_print_valueâ:
../../binutils-gdb/gdb/python/py-framefilter.c:247:7: error: variable
âlocal_indentâ set but not used [-Werror=unused-but-set-variable]
   int local_indent = (4 * indent);
       ^


The first one is here:

      type = check_typedef (value_type (val));
      type_print (value_type (val), "", stb, -1);

Perhaps that call to type_print should use "type".
Or perhaps "type" should be removed.


The second one is here:

  int local_indent = (4 * indent);

  /* Never set an indent level for common_val_print if MI.  */
  if (ui_out_is_mi_like_p (out))
    local_indent = 0;

I think this variable can simply be removed.

-- 
You are receiving this mail because:
You are on the CC list for the bug.

Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]