This is the mail archive of the gdb-prs@sourceware.org mailing list for the GDB project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

[Bug python/16324] py-finishbreakpoint.c incorrect frame_id_eq


https://sourceware.org/bugzilla/show_bug.cgi?id=16324

Phil Muldoon <pmuldoon at redhat dot com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED
                 CC|                            |pmuldoon at redhat dot com
           Assignee|unassigned at sourceware dot org   |pmuldoon at redhat dot com

--- Comment #1 from Phil Muldoon <pmuldoon at redhat dot com> ---
It seems the correct test here is to use frame_id_p which checks if a valid
stack is found (with a simple check to frame_id.stack_status !=
FID_STACK_INVALID). It also checks the frame_id is not an outer frame id.

There is no explicit check for a null_frame_id, which I found odd. get_frame_id
can return a null_frame_id, but lots of callers don't check the return so there
is a latent bug there too.

-- 
You are receiving this mail because:
You are on the CC list for the bug.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]