This is the mail archive of the gdb-prs@sourceware.org mailing list for the GDB project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

[Bug remote/15455] QTro remote packet broken


http://sourceware.org/bugzilla/show_bug.cgi?id=15455

--- Comment #3 from cvs-commit at gcc dot gnu.org <cvs-commit at gcc dot gnu.org> 2013-05-10 13:59:47 UTC ---
CVSROOT:    /cvs/src
Module name:    src
Changes by:    palves@sourceware.org    2013-05-10 13:59:45

Modified files:
    gdb            : ChangeLog remote.c 
    gdb/testsuite  : ChangeLog 
Added files:
    gdb/testsuite/gdb.trace: qtro.c qtro.exp 

Log message:
    PR remote/15455 - QTro remote packet broken

    In the function remote_trace_set_readonly_regions in gdb/remote.c, the
    local variable 'offset' does not account for "QTro" at the start of
    the packet with the result that if there are any read-only regions,
    the packet is sent -- but without the "QTro" -- causing the remote
    stub to report that the packet is unsupported:

    Sending packet: $:0000000000400200,(...),00000000004560a4#ab...Packet
received:

    vs the expected:

    Sending packet: $QTro:0000000000400200,(...),00000000004560a4#31...Packet
received: OK

    We don't see the problem when testing with GDBserver, as that supports
    qXfer:trace-frame-info:read, meaning GDBserver never needs to read
    from the read-only sections directly itself.  This commit adds a test
    that explicitly disables qXfer:trace-frame-info:read.

    gdb/
    2013-05-10  David Taylor  <dtaylor@emc.com>

    PR remote/15455

    * remote.c (remote_trace_set_readonly_regions): Do not overwrite
    "QTro" at start of packet.

    gdb/testsuite/
    2013-05-10  Pedro Alves  <palves@redhat.com>

    PR remote/15455

    * gdb.trace/qtro.c: New file.
    * gdb.trace/qtro.exp: New file.

Patches:
http://sourceware.org/cgi-bin/cvsweb.cgi/src/gdb/ChangeLog.diff?cvsroot=src&r1=1.15543&r2=1.15544
http://sourceware.org/cgi-bin/cvsweb.cgi/src/gdb/remote.c.diff?cvsroot=src&r1=1.544&r2=1.545
http://sourceware.org/cgi-bin/cvsweb.cgi/src/gdb/testsuite/ChangeLog.diff?cvsroot=src&r1=1.3654&r2=1.3655
http://sourceware.org/cgi-bin/cvsweb.cgi/src/gdb/testsuite/gdb.trace/qtro.c.diff?cvsroot=src&r1=1.1&r2=1.2
http://sourceware.org/cgi-bin/cvsweb.cgi/src/gdb/testsuite/gdb.trace/qtro.exp.diff?cvsroot=src&r1=1.1&r2=1.2

-- 
Configure bugmail: http://sourceware.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]