[Bug breakpoints/10645] Watchpoints on unreadable memory need no singlestepping

["jan dot kratochvil at redhat dot com" <sourceware-bugzilla at sourceware dot org>]

------- Additional Comments From jan dot kratochvil at redhat dot com  2009-11-30 17:29 -------
(a) There should be a GNU ChangeLog.  There should be some description text to
include whensubmitting it.  mmap_watchpoints_triggered() has no comment, also
the IMO-tricky fetch_watchpoint_value() call change and the reasons for
`mem_cnt' and `val' checking.  `if (step == 2)' or `else if (step == 1)' are not
acceptable - currently `int step' was a boolean, if it should be tri-state it
should become `enum' (or a new parameter/flag should be provided); this also
affects step_string().  `struct inferior'->trap_syscalls should be removed and
use the existing `catch syscall' infrastructure (I do not know it much so one
should follow it more closely than these comments of mine).  Is the custom
PT_SYSCALL still needed with the existing `catch syscall' infrastructure?

New parts I expected you could implement: (b) Catch also munmap()s.
(c) mmap_watchpoints_triggered() should trigger only on mmap-related syscalls as
detected by the existing `catch syscall' infrastructure.


-- 


http://sourceware.org/bugzilla/show_bug.cgi?id=10645

------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.