This is the mail archive of the
gdb-prs@sourceware.org
mailing list for the GDB project.
Re: mi/2061: malformed +download record on GNU ARM's arm-elf-gdb
- From: Scott Wolchok <scottw at intrepidcs dot com>
- To: nobody at sources dot redhat dot com
- Cc: gdb-prs at sources dot redhat dot com,
- Date: 2 May 2006 19:08:03 -0000
- Subject: Re: mi/2061: malformed +download record on GNU ARM's arm-elf-gdb
- Reply-to: Scott Wolchok <scottw at intrepidcs dot com>
The following reply was made to PR mi/2061; it has been noted by GNATS.
From: Scott Wolchok <scottw@intrepidcs.com>
To: gdb-gnats@sources.redhat.com
Cc:
Subject: Re: mi/2061: malformed +download record on GNU ARM's arm-elf-gdb
Date: Tue, 02 May 2006 15:04:07 -0400
This is a multi-part message in MIME format.
--------------090503040004060900020909
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
The attached patch should rectify the problem. The diff is against
gdb-6.1, but the problem remains in current development sources. I
suppose the best name for the returned value might not be "status", but
I'll leave that debate to the MI maintainer.
-Scott Wolchok
--------------090503040004060900020909
Content-Type: text/plain;
name="download-fix.patch"
Content-Transfer-Encoding: 7bit
Content-Disposition: inline;
filename="download-fix.patch"
diff -rpudb insight-6.1-old/gdb/mi/mi-main.c insight-6.1/gdb/mi/mi-main.c
--- insight-6.1-old/gdb/mi/mi-main.c 2004-02-15 10:22:06.000000000 -0500
+++ insight-6.1/gdb/mi/mi-main.c 2006-05-02 14:59:12.140625000 -0400
@@ -1447,7 +1447,7 @@ mi_load_progress (const char *section_na
if (last_async_command)
fputs_unfiltered (last_async_command, raw_stdout);
fputs_unfiltered ("+download", raw_stdout);
- cleanup_tuple = make_cleanup_ui_out_tuple_begin_end (uiout, NULL);
+ cleanup_tuple = make_cleanup_ui_out_tuple_begin_end (uiout, "status");
ui_out_field_string (uiout, "section", section_name);
ui_out_field_int (uiout, "section-size", total_section);
ui_out_field_int (uiout, "total-size", grand_total);
@@ -1466,7 +1466,7 @@ mi_load_progress (const char *section_na
if (last_async_command)
fputs_unfiltered (last_async_command, raw_stdout);
fputs_unfiltered ("+download", raw_stdout);
- cleanup_tuple = make_cleanup_ui_out_tuple_begin_end (uiout, NULL);
+ cleanup_tuple = make_cleanup_ui_out_tuple_begin_end (uiout, "status");
ui_out_field_string (uiout, "section", section_name);
ui_out_field_int (uiout, "section-sent", sent_so_far);
ui_out_field_int (uiout, "section-size", total_section);
Only in insight-6.1-mod/gdb/mi: tags
--------------090503040004060900020909--