This is the mail archive of the gdb-patches@sourceware.org mailing list for the GDB project.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

Re: [RFAv2] Fix leak in displaced step.

From: Simon Marchi <simon dot marchi at ericsson dot com>
To: David Blaikie <dblaikie at gmail dot com>, Philippe Waroquiers <philippe dot waroquiers at skynet dot be>
Cc: "gdb-patches at sourceware dot org" <gdb-patches at sourceware dot org>
Date: Mon, 12 Nov 2018 16:22:15 +0000
Subject: Re: [RFAv2] Fix leak in displaced step.
References: <20181111121137.6832-1-philippe.waroquiers@skynet.be> <CAENS6EuiKDdWG_oTLOb76b2hg9gdrvm6YCeEbDQN1MZ4FGL-vA@mail.gmail.com>

On 2018-11-12 10:34 a.m., David Blaikie wrote:
> Any chance this could use unique_xmalloc_ptr to reduce the risk of leaking
> a bit? (I guess that'd probably mean handling the ownership of
> displaced_step_inferorior_state, since it'd then have a non-trivial dtor,
> so it couldn't just be xmalloc/xfree'd and would need similar
> unique_xmalloc_ptr handling, etc?)

I think it would be the right way, yes.  If we need the buffer to be resizable,
we could use a vector (gdb::byte_vector), but in any case
displaced_step_inferior_state would need the same treatment.

Simon

References:
- [RFAv2] Fix leak in displaced step.
  - From: Philippe Waroquiers
- Re: [RFAv2] Fix leak in displaced step.
  - From: David Blaikie

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]