Re: [PATCH v2 6/6] Cache a copy of the user's shell on macOS

[Tom Tromey <tom at tromey dot com>]

>>>>> "Simon" == Simon Marchi <simark@simark.ca> writes:

>> +  /* Put the copy somewhere like ~/Library/Caches/gdb/bin/sh.  */
>> +  std::string new_name = get_standard_cache_dir ();
>> +  if (!IS_DIR_SEPARATOR (new_name.back ()) && !IS_ABSOLUTE_PATH (shell))

Simon> I mentioned something about this on the version of the patch, but you might
Simon> have missed it since you didn't reply to that specifically, so I'll send
Simon> it again just to be sure:

Simon> I believe this !IS_ABSOLUTE_PATH check can never be true, since we would
Simon> have returned early if it was the case?  If so, this append is not needed

I will remove the redundant check.
I think I changed this at some point and forgot to update that.

Tom