This is the mail archive of the gdb-patches@sourceware.org mailing list for the GDB project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [RFC] Make "all" depend on "info"


On Saturday, October 20 2018, Tom Tromey wrote:

> I've broken "make info" a couple of times now, because I sometimes
> forget to run "make info" after modifying a Texinfo file.
>
> I don't know why gdb's "make all" doesn't build the info pages.  I
> suspect this was some Cygnus-local oddity back in the day.
>
> This patch changes doc/Makefile.in so that the info pages are built by
> "make all".  As a point of reference, Automake has essentially always
> worked this way.  According to the Automake manual (I didn't
> double-check) this is required by the GNU coding standards.

I think it makes sense, especially because "info" the default
documentation format for GNU.

I was wondering if it would also make sense to build the documentation
on the BuildBot.

> gdb/doc/ChangeLog
> 2018-10-20  Tom Tromey  <tom@tromey.com>
>
> 	* Makefile.in (all): Depend on "info".
> ---
>  gdb/doc/ChangeLog   | 4 ++++
>  gdb/doc/Makefile.in | 2 +-
>  2 files changed, 5 insertions(+), 1 deletion(-)
>
> diff --git a/gdb/doc/Makefile.in b/gdb/doc/Makefile.in
> index 0323bc4ecb..4e167d59cf 100644
> --- a/gdb/doc/Makefile.in
> +++ b/gdb/doc/Makefile.in
> @@ -182,7 +182,7 @@ HAVE_NATIVE_GCORE_TARGET = @HAVE_NATIVE_GCORE_TARGET@
>  
>  ###
>  
> -all:
> +all: info
>  
>  info: $(INFO_DEPS)
>  dvi: gdb.dvi stabs.dvi refcard.dvi annotate.dvi
> -- 
> 2.17.1

-- 
Sergio
GPG key ID: 237A 54B1 0287 28BF 00EF  31F4 D0EB 7628 65FC 5E36
Please send encrypted e-mail if possible
http://sergiodj.net/


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]