This is the mail archive of the gdb-patches@sourceware.org mailing list for the GDB project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [RFA] Remove some unnecessary declarations and configury


On 2018-07-23 01:32 PM, Simon Marchi wrote:
> On 2018-07-22 11:36 AM, Tom Tromey wrote:
>> configure checks for declarations of free, malloc, and realloc; but
>> the results are only used in a single spot: utils.c.  I think these
>> checks are long since obsolete, so this patch removes them.
>>
>> Grepping the entire tree for these HAVE_DECL_ symbols, the only uses
>> of possible interest to gdb come from bfd/sysdep.h; but this is not
>> (nor should be) included by gdb.  (And furthermore I think the code
>> there is probably also obsolete.)
> 
> I'm really not an expert of old arcane systems, but I don't think any
> platform we support today needs this.
> 
> Simon
> 

I should clarify that this patch LGTM.

Thanks,

Simon


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]