This is the mail archive of the gdb-patches@sourceware.org mailing list for the GDB project.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

Re: [RFA 10/13] Remove unused declaration from value.c

From: Tom Tromey <tom at tromey dot com>
To: Pedro Alves <palves at redhat dot com>
Cc: Simon Marchi <simark at simark dot ca>, Tom Tromey <tom at tromey dot com>, gdb-patches at sourceware dot org
Date: Mon, 16 Jul 2018 09:34:23 -0600
Subject: Re: [RFA 10/13] Remove unused declaration from value.c
References: <20180712205208.32646-1-tom@tromey.com> <20180712205208.32646-11-tom@tromey.com> <97a938d0-3cf4-dc2a-b572-6e55b824cf98@simark.ca> <877elyc11j.fsf@tromey.com> <e914b544ee0626291ab649ee861a491d@simark.ca> <53ef4f69-ce98-a6e6-50b9-34b449b03a9e@redhat.com>

>>>>> "Pedro" == Pedro Alves <palves@redhat.com> writes:

Simon> Then my opinion would be to check if removing it causes any test
Simon> failure.  If not, I'd remove it (in its own commit such as this
Simon> patch is good, so it's easy to bisect if needed).

Pedro> Agreed.  If/when we find out it was needed, we can add
Pedro> a testcase then.

I've made this change.

Tom

References:
- [RFA 00/13] Add -Wunused-variable
  - From: Tom Tromey
- [RFA 10/13] Remove unused declaration from value.c
  - From: Tom Tromey
- Re: [RFA 10/13] Remove unused declaration from value.c
  - From: Simon Marchi
- Re: [RFA 10/13] Remove unused declaration from value.c
  - From: Tom Tromey
- Re: [RFA 10/13] Remove unused declaration from value.c
  - From: Simon Marchi
- Re: [RFA 10/13] Remove unused declaration from value.c
  - From: Pedro Alves

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]