This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [RFA 06/42] Move have_line_numbers to buildsym_compunit
- From: Tom Tromey <tom at tromey dot com>
- To: Keith Seitz <keiths at redhat dot com>
- Cc: Tom Tromey <tom at tromey dot com>, gdb-patches at sourceware dot org
- Date: Sun, 08 Jul 2018 10:26:48 -0600
- Subject: Re: [RFA 06/42] Move have_line_numbers to buildsym_compunit
- References: <20180523045851.11660-1-tom@tromey.com> <20180523045851.11660-7-tom@tromey.com> <62ee17d0-af6d-5fde-855f-52b9a8d87189@redhat.com>
>>>>> "Keith" == Keith Seitz <keiths@redhat.com> writes:
>> - && have_line_numbers == 0
>> + && buildsym_compunit->m_have_line_numbers == 0
Keith> Since m_have_line_numbers was declared bool, I prefer (and I
Keith> think most do?) that the comparison use `false' instead.
I changed it to just !have_line_numbers.
Tom