This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [RFA v2 2/4] Initial support for variant parts
On Thu, Feb 22, 2018 at 01:30:16PM -0700, Tom Tromey wrote:
> This adds some initial support for variant parts to gdbtypes.h. A
> variant part is represented as a union. The union has a flag
> indicating that it has a discriminant, and information about the
> discriminant is attached using the dynamic property system.
>
> 2018-02-22 Tom Tromey <tom@tromey.com>
>
> * value.h (value_union_variant): Declare.
> * valops.c (value_union_variant): New function.
> * gdbtypes.h (TYPE_FLAG_DISCRIMINATED_UNION): New macro.
> (struct discriminant_info): New.
> (enum dynamic_prop_node_kind) <DYN_PROP_DISCRIMINATED>: New
> enumerator.
> (struct main_type) <flag_discriminated_union>: New field.
OK, with just one minor typo below...
> + /* Compute the discriminant. Note that unpack_field_as_long handles
> + sign extension when necessary, as does the DWARF reader -- so
> + signed discriminants will be handled correct despite the use of
correct -> correctly
Thanks!
--
Joel