This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [RFA] Remove most cleanups from linux-thread-db.c
- From: Simon Marchi <simark at simark dot ca>
- To: Tom Tromey <tom at tromey dot com>, gdb-patches at sourceware dot org
- Date: Fri, 23 Feb 2018 21:17:32 -0500
- Subject: Re: [RFA] Remove most cleanups from linux-thread-db.c
- Authentication-results: sourceware.org; auth=none
- References: <20180222170248.27265-1-tom@tromey.com>
Hi Tom,
LGTM, just one nit:
On 2018-02-22 12:02 PM, Tom Tromey wrote:
> @@ -1559,22 +1528,21 @@ thread_db_resume (struct target_ops *ops,
> beneath->to_resume (beneath, ptid, step, signo);
> }
>
> -/* qsort helper function for info_auto_load_libthread_db, sort the
> +/* std:;sort helper function for info_auto_load_libthread_db, sort the
std:;sort -> std::sort
info_auto_load_libthread_db is a little bit hard to follow and there's no
test for it, so I tested it by hand and it seems to work fine with the patch
applied. In order to be able to test it using my system libthread_db, I copied
it to two directories, started two inferiors, setting "set libthread-db-search-path"
to one directory then the other. Otherwise, "info auto-load libthread-db" doesn't
do any meaningful work.
Simon