This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [RFA 0/3] Discriminated unions
- From: Joel Brobecker <brobecker at adacore dot com>
- To: Tom Tromey <tom at tromey dot com>
- Cc: gdb-patches at sourceware dot org
- Date: Wed, 21 Feb 2018 08:44:08 +0400
- Subject: Re: [RFA 0/3] Discriminated unions
- Authentication-results: sourceware.org; auth=none
- References: <20180220190613.24148-1-tom@tromey.com>
Hi Tom,
> This series provides a minimal implementation of DW_TAG_variant and
> DW_TAG_variant_part reading for gdb. It also converts the Rust
> language support to use this new approach. The Rust changes are
> motivated by some work to change how the Rust compiler emits enums;
> see:
>
> https://github.com/rust-lang/rust/issues/32920
>
> A DW_TAG_variant is represented in gdb as a union with some extra
> information about how to compute the discriminant and thus find the
> active variant part.
Nice work! I only have minor comments/questions...
--
Joel