This is the mail archive of the gdb-patches@sourceware.org mailing list for the GDB project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [RFA 0/3] Discriminated unions


Hi Tom,

> This series provides a minimal implementation of DW_TAG_variant and
> DW_TAG_variant_part reading for gdb.  It also converts the Rust
> language support to use this new approach.  The Rust changes are
> motivated by some work to change how the Rust compiler emits enums;
> see:
> 
>     https://github.com/rust-lang/rust/issues/32920
> 
> A DW_TAG_variant is represented in gdb as a union with some extra
> information about how to compute the discriminant and thus find the
> active variant part.

Nice work! I only have minor comments/questions...

-- 
Joel


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]