This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [RFA] Fix frame argument printing when using auto language mode
- From: Yao Qi <qiyaoltc at gmail dot com>
- To: Xavier Roirand <roirand at adacore dot com>
- Cc: GDB Patches <gdb-patches at sourceware dot org>, Joel Brobecker <brobecker at adacore dot com>
- Date: Tue, 20 Feb 2018 16:48:33 +0000
- Subject: Re: [RFA] Fix frame argument printing when using auto language mode
- Authentication-results: sourceware.org; auth=none
- References: <1519044767-8741-1-git-send-email-roirand@adacore.com> <CAH=s-PM+9dGs12pLNDZTcr69tdkTMDdyFhAwhHHL037vkvqCKQ@mail.gmail.com> <fc85a90b-93b3-0b75-6a37-dc58be650d80@adacore.com>
On Tue, Feb 20, 2018 at 4:28 PM, Xavier Roirand <roirand@adacore.com> wrote:
>
> It was my first idea, but it would imply a consequent amount of work because
> when ada_val_print_1 is called, the stack is the following one:
>
> #0 ada_val_print_1
> #1 ada_val_print
> #2 val_print (got the language of the frame arg)
>
> So if we want to pass the per-frame language down to ada_val_print_1 then in
> the generic val_print function, we have to change:
>
> language->la_val_print (type, embedded_offset, address,
> stream, recurse, val,
> &local_opts);
> to something like:
>
> language->la_val_print (type, embedded_offset, address,
> stream, recurse, val,
> &local_opts, language);
> ^^^^^^^^
>
We don't have to do that. ada_val_print_1 is called in ada_val_print,
ada_val_print_1 (type, embedded_offset, address,
stream, recurse, val, options,
current_language);
and ada_val_print is language->la_val_print in effect, so "language"
is ada_language_defn, and we can rewrite the code above like this,
ada_val_print_1 (type, embedded_offset, address,
stream, recurse, val, options,
&ada_language_defn);
This change may break existing behaviour. Printing for ada (or other
languages) shouldn't depend on current_language, IMO.
> Fix me if I'm wrong but it means that <language>_val_print functions for all
> the supported GDB languages have to be modified in order to support the
> language parameter.
>
--
Yao (齐尧)