This is the mail archive of the gdb-patches@sourceware.org mailing list for the GDB project.

Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH v2 1/7] common: add scoped_fd

On Tue, Feb 20, 2018 at 10:46 AM, Metzger, Markus T
<markus.t.metzger@intel.com> wrote:
> ---
> diff --git a/gdb/gnulib/update-gnulib.sh b/gdb/gnulib/update-gnulib.sh
> index 55cd6e0..d026536 100755
> --- a/gdb/gnulib/update-gnulib.sh
> +++ b/gdb/gnulib/update-gnulib.sh
> @@ -59,6 +59,7 @@ IMPORTED_GNULIB_MODULES="\
>      update-copyright \
>      wchar \
>      wctype-h \
> +    mkstemp \
>  "
>

We should keep IMPORTED_GNULIB_MODULES in alphabetical order.
Otherwise, patch is good to me.

>
> I have not tried building GDB with mingw cross tools, yet.  Would you be able to test whether
> this solves your build problem, Yao?
>

Yes, it fixed my build problem.

-- 
Yao (齐尧)
Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]