Re: [PATCH] Add common/ dir in build directories

[Alan Hayward <Alan dot Hayward at arm dot com>]

> On 16 Feb 2018, at 15:37, Yao Qi <qiyaoltc@gmail.com> wrote:
> 
> Alan Hayward <Alan.Hayward@arm.com> writes:
> 
>> Tested the new patch with the above combinations.
>> 
>> Using x86_64-w64-mingw32-gcc (GCC) 4.8.2 on ubuntu 14.04,
>> I have a build failure against HEAD for mingw32:
>> unittests/scoped_fd-selftests.c fails because it cannot find mkstemp().
>> Not sure if this is a bug, or error in my setup.
>> Commenting out mkstemp code fixes my builds.
>> 
> 
> I reported it https://sourceware.org/ml/gdb-patches/2018-02/msg00186.html
> If you see something wrong in the committed patches, better to reply to
> the patch review email thread, so that you can remind patch author and
> reviewers.
> 
> Patch is good me, some nits on changelog,
> 

Thanks!
Pushed with changeling differences as suggested.

Alan.


>> 
>> gdb/ChangeLog:
>> 
>> 2018-02-13  Alan Hayward  <alan.hayward@arm.com>
>> 
>> 	* Makefile.in: Add common directory in build.
> 
> Better to document what do you change, like,
> 
> 	* Makefile.in (COMMON_SFILES): Add common/*.c files.
>        (SFILES): Remove common/*.c files.
>        (COMMON_OBS): Remove some *.o files built from common/*.c
>        files.
>        Remove rules for common/*.c files.
> 
>> 	* common/common.host: Add common reference.
>> 	* configure: Likewise.
> 
> configure is generated by autoconf, so we write
> 
> 	* configure: Regenerate.
> 
>> 	* configure.ac: Likewise.
>> 
>> gdb/gdbserver/ChangeLog:
>> 
>> 2018-02-13  Alan Hayward  <alan.hayward@arm.com>
>> 
>> 	* Makefile.in: Add common directory in build.
>> 	* configure: Add common reference.
>> 	* configure.ac: Likewise.
> 
> -- 
> Yao (齐尧)