This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [PATCH] WebAssembly: Disable subdirectory configuration for unsupported LD
- From: Pip Cet <pipcet at gmail dot com>
- To: "Maciej W. Rozycki" <macro at mips dot com>
- Cc: binutils at sourceware dot org, gdb-patches at sourceware dot org, gcc-patches at gcc dot gnu dot org
- Date: Sun, 4 Feb 2018 14:52:29 +0000
- Subject: Re: [PATCH] WebAssembly: Disable subdirectory configuration for unsupported LD
- Authentication-results: sourceware.org; auth=none
- References: <alpine.DEB.2.00.1802030457060.3553@tp.orcam.me.uk>
Hello Maciej,
thank you for looking at this code! The change looks obviously correct to me.
Regards
Pip
On Sat, Feb 3, 2018 at 3:16 PM, Maciej W. Rozycki <macro@mips.com> wrote:
> Remove an LD subdirectory configuration error:
>
> *** ld does not support target wasm32-unknown-none
> *** see ld/configure.tgt for supported targets
> make[1]: *** [configure-ld] Error 1
>
> which prevents binutils for the WebAssembly target from being built
> unless an explicit `--disable-ld' configuration option has been given.
> Users must not have to disable features selected by default to get a
> working configuration.
>
> /
> * configure.ac <wasm32-*-*> (noconfigdirs): Add `ld'.
> * configure: Regenerate.
> ---
> Hi,
>
> It should be obvious. Also this causes troubles with cross-target
> testing. OK to apply?
>
> Maciej
> ---
> configure | 3 +++
> configure.ac | 3 +++
> 2 files changed, 6 insertions(+)
>
> binutils-wasm32-no-ld.diff
> Index: binutils/configure
> ===================================================================
> --- binutils.orig/configure 2018-01-28 00:48:43.000000000 +0000
> +++ binutils/configure 2018-02-02 05:48:19.239569799 +0000
> @@ -3860,6 +3860,9 @@ case "${target}" in
> vax-*-*)
> noconfigdirs="$noconfigdirs target-newlib target-libgloss"
> ;;
> + wasm32-*-*)
> + noconfigdirs="$noconfigdirs ld"
> + ;;
> esac
>
> # If we aren't building newlib, then don't build libgloss, since libgloss
> Index: binutils/configure.ac
> ===================================================================
> --- binutils.orig/configure.ac 2018-01-28 00:48:43.000000000 +0000
> +++ binutils/configure.ac 2018-02-02 05:48:09.444938712 +0000
> @@ -1191,6 +1191,9 @@ case "${target}" in
> vax-*-*)
> noconfigdirs="$noconfigdirs target-newlib target-libgloss"
> ;;
> + wasm32-*-*)
> + noconfigdirs="$noconfigdirs ld"
> + ;;
> esac
>
> # If we aren't building newlib, then don't build libgloss, since libgloss