Re: [PATCH 4/4] (Ada) Add gdb-mi support for stopping at start of exception handler.

[Joel Brobecker <brobecker at adacore dot com>]

On Tue, Jan 30, 2018 at 10:24:12AM +0100, Xavier Roirand wrote:
> Following my previous commit which add support for stopping at start of
> exception handler, this commit adds required gdb-mi support for this
> feature.
> 
> gdb/ChangeLog:
> 
>     * mi/mi-cmd-catch.c (mi_cmd_catch_handlers): New function.
>     * mi/mi-cmds.c (mi_cmds): Add catch-handlers command.
>     * mi/mi-cmds.h (mi_cmd_catch_handlers): Add external declaration.
>     * NEWS: Document "-catch-handlers" command.
> 
> gdb/doc/ChangeLog:
> 
>     * gdb.texinfo (Ada Exception gdb/mi Catchpoints): Add
>     documentation for new "-catch-handlers" command.
> 
> gdb/testsuite/ChangeLog:
> 
>     * gdb.ada/mi_catch_ex_hand.exp: New testcase.
>     * gdb.ada/mi_catch_ex_hand/foo.adb: New file.
> 
> Tested on x86_64-linux.

One minor issue where you misunderstood what I was suggesting:

> +# We don't have the exception name info when stopping at the exception handlers
> +# breakpoints so we use source line to check if the inferior stops at the

I wasn't suggesting you pluralize "breakpoints" (although, not a bad
idea), but rather use "catchpoint" rather than "breakpoint". From
the user's perspective, we are stopping at a catchpoint, not a
breakpoint.

Pre-approved with that change made.
-- 
Joel