This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [PATCH v2] Do not classify C struct members as a filename
- From: "Leszek Swirski via gdb-patches" <gdb-patches at sourceware dot org>
- To: Simon Marchi <simon dot marchi at polymtl dot ca>
- Cc: gdb-patches at sourceware dot org
- Date: Thu, 25 Jan 2018 10:03:58 +0000
- Subject: Re: [PATCH v2] Do not classify C struct members as a filename
- Authentication-results: sourceware.org; auth=none
- References: <20180124165107.186980-1-leszeks@google.com> <6c3f1fc7d56feaaa00ade76f51f7421f@polymtl.ca>
- Reply-to: Leszek Swirski <leszeks at google dot com>
>
> I was able to reproduce the problem and confirmed that the patch fixes
> it. I'm not very strong in the lexing/parsing area, but the change in
> c-exp.y makes sense to me. I'd like to give others a chance to comment, so
> let's wait a few days. If nobody answer, we can merge it. One nit, since
> we are now using C++, can you use bool instead of int? It won't match the
> old surrounding code, but that's a good reason to modernize the existing
> code later :).
>
> Do you know if we have a test for the same thing, but with the "this"
> pointer (which was already worked before this patch)? If not, it would be
> nice to add it to the test as well. You could add a call to D::includefile
> and continue/break there. From there, you could test calling
> this->includefile().
Hi Simon, thanks for taking a look.
Sure, I can update the tests (I'll add some tests for checking
"c.includefile" while I'm at it) and change the int to a bool. I'm not 100%
sure on the procedure here, do you want me to upload a v3 as a new thread?
- Leszek