This is the mail archive of the gdb-patches@sourceware.org mailing list for the GDB project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH 2/2] gdb: Add missing #ifdef USE_THREAD_DB to gdbserver


On 19 Jan 2018, at 16:57, Pedro Alves <palves@redhat.com> wrote:
> On 01/19/2018 04:55 PM, James Clarke wrote:
>> On 19 Jan 2018, at 16:48, Pedro Alves <palves@redhat.com> wrote:
>>> On 12/15/2017 12:04 AM, James Clarke wrote:
>>>> gdb/ChangeLog:
>>>> 	* gdbserver/linux-low.c (handle_extended_wait): Surround call to
>>>> 	thread_db_notice_clone with #ifdef USE_THREAD_DB.
>>>> ---
>>>> [Originally erroneously sent to the binutils mailing list]
>>> 
>>> Looks OK, but could you remind me what goes wrong if we
>>> don't do this?  Does gdbserver fail to link?
>> 
>> Yes, with the expected:
>> 
>>> [...]/linux-low.c:664: undefined reference to `thread_db_notice_clone(thread_info*, ptid_t)'
>> 
>> Every other use of thread_db_* is guarded by USE_THREAD_DB, so I assume it's
>> fine to do here too.
> 
> Thanks for the clarification.  Please add that to the commit log,
> and push it in.

I don't have push rights, so I'll email a v2 to be committed on my behalf.

Regards,
James


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]