This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [PATCH 1/2] gdb: Fix ia64 defining TRAP_HWBKPT before including gdb_wait.h
- From: Pedro Alves <palves at redhat dot com>
- To: James Clarke <jrtc27 at jrtc27 dot com>, gdb-patches at sourceware dot org
- Date: Fri, 19 Jan 2018 16:43:49 +0000
- Subject: Re: [PATCH 1/2] gdb: Fix ia64 defining TRAP_HWBKPT before including gdb_wait.h
- Authentication-results: sourceware.org; auth=none
- References: <20171215000434.47315-1-jrtc27@jrtc27.com>
On 12/15/2017 12:04 AM, James Clarke wrote:
> On ia64, gdb_wait.h eventually includes siginfo-consts-arch.h, which
> contains an enum with TRAP_HWBKPT, along with a #define. Thus we cannot
> define TRAP_HWBKPT to 4 beforehand, and so gdb_wait.h must be included
> earlier; include it from linux-ptrace.h so it can never come afterwards.
OK.
This allows moving the linux-specific __WCLONE from
gdb_wait.h > linux-ptrace.h, to have it live near where its
sibling __WALL is defined, I think. (not sure we still support
any system where those two are missing, though. Maybe we could
just zap them too.)
Thanks,
Pedro Alves